Bug 29810

Summary:

[V8] Unsigned int return values are incorrectly treated as signed.

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, levin, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Fixed type-conversion error in CodeGeneratorV8.pm, v1.	abarth: review+, commit-queue: commit-queue-
Add index arguments special case, v1.	levin: review+

Dimitri Glazkov (Google)

Reported 2009-09-28 09:11:29 PDT

In CodeGeneratorV8.pm, "unsigned long" return value in IDL incorrectly generates "int" in C++. It should be "unsigned" instead.

Attachments
Fixed type-conversion error in CodeGeneratorV8.pm, v1. (1.42 KB, patch) 2009-09-28 09:12 PDT, Dimitri Glazkov (Google)	abarth: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Add index arguments special case, v1. (1.42 KB, patch) 2009-09-28 10:53 PDT, Dimitri Glazkov (Google)	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2009-09-28 09:12:47 PDT

Created attachment 40238 [details] Fixed type-conversion error in CodeGeneratorV8.pm, v1. WebCore/ChangeLog | 13 +++++++++++++ WebCore/bindings/scripts/CodeGeneratorV8.pm | 3 ++- 2 files changed, 15 insertions(+), 1 deletions(-)

Adam Barth

Comment 2 2009-09-28 09:15:32 PDT

Comment on attachment 40238 [details] Fixed type-conversion error in CodeGeneratorV8.pm, v1. Nice! I presume the test mentioned already exists.

Dimitri Glazkov (Google)

Comment 3 2009-09-28 09:21:56 PDT

Yep. tkent wrote it :)

Dimitri Glazkov (Google)

Comment 4 2009-09-28 09:29:40 PDT

Landed as http://trac.webkit.org/changeset/48817.

Dimitri Glazkov (Google)

Comment 5 2009-09-28 10:48:10 PDT

Oops. I maked bugs. Fix coming up.

Dimitri Glazkov (Google)

Comment 6 2009-09-28 10:53:24 PDT

Created attachment 40245 [details] Add index arguments special case, v1. WebCore/ChangeLog | 13 +++++++++++++ WebCore/bindings/scripts/CodeGeneratorV8.pm | 5 +++++ 2 files changed, 18 insertions(+), 0 deletions(-)

Dimitri Glazkov (Google)

Comment 7 2009-09-28 10:53:52 PDT

Fix uploaded. Sorry for the troubles.

WebKit Commit Bot

Comment 8 2009-09-28 10:54:18 PDT

Comment on attachment 40238 [details] Fixed type-conversion error in CodeGeneratorV8.pm, v1. Rejecting patch 40238 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=40238 from bug 29810 failed to download and apply.

Dimitri Glazkov (Google)

Comment 9 2009-09-28 10:57:52 PDT

Fix landed as http://trac.webkit.org/changeset/48820.

Eric Seidel (no email)

Comment 10 2009-09-28 13:24:00 PDT

patching file WebCore/bindings/scripts/CodeGeneratorV8.pm Hunk #1 FAILED at 1711. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/bindings/scripts/CodeGeneratorV8.pm.rej Was the cause of the rejection.

Note You need to log in before you can comment on or make changes to this bug.