Summary: | [V8] Unsigned int return values are incorrectly treated as signed. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, levin, tkent | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2009-09-28 09:11:29 PDT
Created attachment 40238 [details]
Fixed type-conversion error in CodeGeneratorV8.pm, v1.
WebCore/ChangeLog | 13 +++++++++++++
WebCore/bindings/scripts/CodeGeneratorV8.pm | 3 ++-
2 files changed, 15 insertions(+), 1 deletions(-)
Comment on attachment 40238 [details]
Fixed type-conversion error in CodeGeneratorV8.pm, v1.
Nice! I presume the test mentioned already exists.
Yep. tkent wrote it :) Landed as http://trac.webkit.org/changeset/48817. Oops. I maked bugs. Fix coming up. Created attachment 40245 [details]
Add index arguments special case, v1.
WebCore/ChangeLog | 13 +++++++++++++
WebCore/bindings/scripts/CodeGeneratorV8.pm | 5 +++++
2 files changed, 18 insertions(+), 0 deletions(-)
Fix uploaded. Sorry for the troubles. Comment on attachment 40238 [details] Fixed type-conversion error in CodeGeneratorV8.pm, v1. Rejecting patch 40238 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=40238 from bug 29810 failed to download and apply. Fix landed as http://trac.webkit.org/changeset/48820. patching file WebCore/bindings/scripts/CodeGeneratorV8.pm Hunk #1 FAILED at 1711. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/bindings/scripts/CodeGeneratorV8.pm.rej Was the cause of the rejection. |