| Summary: | [Qt] assertions to be visible on Symbian | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Janne Koskinen <koshuin> | ||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer | ||||||||
| Priority: | P3 | Keywords: | Qt | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | S60 Hardware | ||||||||||
| OS: | S60 3rd edition | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 27065 | ||||||||||
| Attachments: |
|
||||||||||
Comment on attachment 40236 [details] vprintf patch > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > index f6a644a..894ff9a 100644 > --- a/JavaScriptCore/ChangeLog > +++ b/JavaScriptCore/ChangeLog > @@ -1,3 +1,15 @@ > +2009-09-28 Janne Koskinen <janne.p.koskinen@digia.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] Assert messages prints visible in Symbian > + > + Asserts use vprintf to print the messages to stderr. > + In Symbian Open C it is not possible to see stderr so > + I routed the messages to stdout instead. > + > + * wtf/Assertions.cpp: > + Please include a reference to the bug URL in the ChangeLog entry. > +#ifdef PLATFORM(SYMBIAN) This should be: #if PLATFORM(SYMBIAN) r- to address the above issues. Created attachment 40286 [details]
vprintf patch second attempt
Corrected patch based on review comments.
Created attachment 40287 [details]
vprintf patch third attempt
Corrected based on review comments.
Added bug url and changed to use #if instead of #ifdef.
Comment on attachment 40287 [details]
vprintf patch third attempt
r=me
Comment on attachment 40287 [details] vprintf patch third attempt Clearing flags on attachment: 40287 Committed r48878: <http://trac.webkit.org/changeset/48878> All reviewed patches have been landed. Closing bug. |
Created attachment 40236 [details] vprintf patch Qt port of Symbian uses Open C to access posix libraries. assertions.h uses vprintf to print out the assert messages into stderr. In Open C stderr prints are lost somewhere and only stdout can be seen from log files. This change that makes assert messages to be visible on Symbian.