Bug 29808

Summary: [Qt] assertions to be visible on Symbian
Product: WebKit Reporter: Janne Koskinen <koshuin>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, ddkilzer
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Description Flags
vprintf patch
ddkilzer: review-
vprintf patch second attempt
vprintf patch third attempt none

Description Janne Koskinen 2009-09-28 08:32:33 PDT
Created attachment 40236 [details]
vprintf patch

Qt port of Symbian uses Open C to access posix libraries.
assertions.h uses vprintf to print out the assert messages into stderr.
In Open C stderr prints are lost somewhere and only stdout can be seen from
log files. This change that makes assert messages to be visible on Symbian.
Comment 1 David Kilzer (:ddkilzer) 2009-09-28 16:35:00 PDT
Comment on attachment 40236 [details]
vprintf patch

> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index f6a644a..894ff9a 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,15 @@
> +2009-09-28  Janne Koskinen  <janne.p.koskinen@digia.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] Assert messages prints visible in Symbian
> +
> +        Asserts use vprintf to print the messages to stderr.
> +        In Symbian Open C it is not possible to see stderr so
> +        I routed the messages to stdout instead.
> +
> +        * wtf/Assertions.cpp:
> +

Please include a reference to the bug URL in the ChangeLog entry.


This should be:


r- to address the above issues.
Comment 2 Janne Koskinen 2009-09-29 00:38:50 PDT
Created attachment 40286 [details]
vprintf patch second attempt

Corrected patch based on review comments.
Comment 3 Janne Koskinen 2009-09-29 00:48:38 PDT
Created attachment 40287 [details]
vprintf patch third attempt

Corrected based on review comments.
Added bug url and changed to use #if instead of #ifdef.
Comment 4 David Kilzer (:ddkilzer) 2009-09-29 09:01:23 PDT
Comment on attachment 40287 [details]
vprintf patch third attempt

Comment 5 WebKit Commit Bot 2009-09-29 09:10:30 PDT
Comment on attachment 40287 [details]
vprintf patch third attempt

Clearing flags on attachment: 40287

Committed r48878: <http://trac.webkit.org/changeset/48878>
Comment 6 WebKit Commit Bot 2009-09-29 09:10:45 PDT
All reviewed patches have been landed.  Closing bug.