Summary: | [GTK] Crash when right-clicking misspelled word | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Christian Dywan <christian> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | darin, David.Ronis, gustavo, jmalonzo, pochu27 | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Christian Dywan
2009-09-26 15:55:04 PDT
Created attachment 40182 [details]
Make sure dicts exist
With this change enchant is asked for every dictionary whether it actually exists, otherwise it is not added to the list.
I've been experiencing a crash in liferea (https://sourceforge.net/tracker/?func=detail&atid=581684&aid=2865307&group_id=87005) which the developers think is related to this issue. I applied the patch and it still crashes. Either the patch is bad, or the issue is different. I'd appreciate your comments. Comment on attachment 40182 [details]
Make sure dicts exist
r=me, I'm setting cq-, because I assume you are going to commit yourself =).
(In reply to comment #2) > I've been experiencing a crash in liferea > (https://sourceforge.net/tracker/?func=detail&atid=581684&aid=2865307&group_id=87005) > which the developers think is related to this issue. I applied the patch and > it still crashes. Either the patch is bad, or the issue is different. I'd > appreciate your comments. OK, so this has absolutely no relation to this problem. The dictionary the trace refers to is related to javascript properties mapping/caching, rather than to spelling. If that is webkit 1.1.15, I highly recommend upgrading to 1.1.15.1. If you can still reproduce that crash with 1.1.15.1, please file a bug report specifically for it. (In reply to comment #3) > (From update of attachment 40182 [details]) > r=me, I'm setting cq-, because I assume you are going to commit yourself =). Landed as http://trac.webkit.org/changeset/49437. This patch also fixed a few critical warnings wrt enchant in some layout tests, which is why I landed it. I hope that's ok. |