Bug 29771

Summary: "Use of uninitialized value $result" warnings when ignoring metrics in run-webkit-tests.
Product: WebKit Reporter: Jakub Wieczorek <jwieczorek>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Do not strip the metrics when there is no expected result for a test. none

Jakub Wieczorek
Reported 2009-09-26 13:14:45 PDT
When a test is new, i.e. it doesn't have the expected result, running the test without metrics (--ignore-metrics) results in a bunch of following warnings: Use of uninitialized value $result in substitution (s///) at (...)/WebKitTools/Scripts/run-webkit-tests line 1951, <IN> line 512. There is no point in stripping metrics when there is no result for a test.
Attachments
Do not strip the metrics when there is no expected result for a test. (1.47 KB, patch)
2009-09-26 13:20 PDT, Jakub Wieczorek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakub Wieczorek
Comment 1 2009-09-26 13:20:23 PDT
Created attachment 40179 [details] Do not strip the metrics when there is no expected result for a test.
WebKit Commit Bot
Comment 2 2009-09-27 12:45:32 PDT
Comment on attachment 40179 [details] Do not strip the metrics when there is no expected result for a test. Clearing flags on attachment: 40179 Committed r48803: <http://trac.webkit.org/changeset/48803>
WebKit Commit Bot
Comment 3 2009-09-27 12:45:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.