Bug 297485
| Summary: | webkitscmpy.local.git.Git.branch shouldn't call git-status | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Ryan Haddad <ryanhaddad> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfan2, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
This is:
https://github.com/WebKit/WebKit/blob/42ff38fd1cc95732e666dd3ea2c0c599892e9118/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py#L482-L486
If we're only interested in "is this a detached head", we probably should just call `git symbolic-ref -q HEAD`, as it is (locally, on my current WebKit working copy) 150x quicker (4ms instead of 600ms).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/158438687>
Ryan Haddad
Pull request: https://github.com/WebKit/WebKit/pull/52090
EWS
Committed 301587@main (32c25bb712d4): <https://commits.webkit.org/301587@main>
Reviewed commits have been landed. Closing PR #52090 and removing active labels.