Bug 297450
| Summary: | [GTK][WPE][WebXR] Add the XR session permission request | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <fujii> |
| Component: | WPE WebKit | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino |
| Priority: | P2 | Keywords: | DoNotImportToRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=298178 | ||
Fujii Hironori
[GTK][WPE][WebXR] Add the XR session permission request
https://immersive-web.github.io/webxr/#permissions
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/49447
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/49631
EWS
Committed 298944@main (fcc54d1d1bb4): <https://commits.webkit.org/298944@main>
Reviewed commits have been landed. Closing PR #49631 and removing active labels.
Diego Pino
There was a build error in Debian Stable (and other bots) after this commit:
https://build.webkit.org/#/builders/46/builds/53974
In file included from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/Source/WebKit/UIProcess/API/glib/WebKitXRPermissionRequest.cpp:25:
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/Source/WebKit/UIProcess/API/glib/WebKitXRPermissionRequestPrivate.h:26:139: error: ‘Device’ in namespace ‘PlatformXR’ does not name a type
26 | WebKitXRPermissionRequest* webkitXRPermissionRequestCreate(const WebCore::SecurityOriginData&, PlatformXR::SessionMode, const PlatformXR::Device::FeatureList& granted, CompletionHandler<void(std::optional<PlatformXR::Device::FeatureList>&&)>&&);
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/49647
EWS
Committed 298950@main (37d0f544abce): <https://commits.webkit.org/298950@main>
Reviewed commits have been landed. Closing PR #49647 and removing active labels.
Diego Pino
It seems the follow-up fixed some bots but not all of them. Some are failing with this build error:
https://build.webkit.org/#/builders/46/builds/53981
```
/usr/bin/ld: /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/tmp-introspectdewj2lne/WebKit-6.0.o:(.data.rel.GI_GET_TYPE_FUNCS_+0x3a8): undefined reference to `webkit_xr_permission_request_get_type'
collect2: error: ld returned 1 exit status
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/49671
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/49696
EWS
Committed 298995@main (9759e0845dc9): <https://commits.webkit.org/298995@main>
Reviewed commits have been landed. Closing PR #49696 and removing active labels.