Summary: | Gmail: After changing a foreground text color, pressing return doesn't apply background to new line | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adele, eric, rniwa | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Enrica Casucci
2009-09-25 09:44:56 PDT
Created attachment 40118 [details]
Patch
Adding the patch.
I'm going to commit this. Comment on attachment 40118 [details] Patch I was about to say r=me, but Adele beat me to it. > +void InsertParagraphSeparatorCommand::ancestorsInsideBlock(const Node* insertionNode, Element* outerBlock, Vector<Element*>& ancestors) Functions with an out argument like this have "get" in their name in the WebKit coding style, so this should be named getAncestorsInsideBlock. But I just realized this is not in the coding style document. We should add that! This also requires an empty vector, because it appends, but does not clear the vector. That's probably OK. I'm not sure. r=me but please add the "get" Created attachment 40125 [details]
Patch2
New patch that includes the name change (getAncestorsInsideBlock) and the clear of the vector before appending.
<rdar://problem/7168738> Committed revision 48764. |