Bug 29738
| Summary: | Revert JavaScriptCore RefPtr and PassRefPtr changes when winscw bug gets fixed. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yongjun Zhang <yongjun.zhang> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | S60 Emulator | ||
| OS: | S60 3rd edition | ||
| Bug Depends on: | 28054, 29187 | ||
| Bug Blocks: | 27065 | ||
Yongjun Zhang
In RefPtr and PassRefPtr, a helper function is introduced (derefIfNotNull) to get around a known Winscw bug (https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812).
The change should be reverted if the above mentioned bug is fixed in winscw compiler side.
Following patches are introduced into JavascriptCore:
https://bugs.webkit.org/show_bug.cgi?id=28054
https://bugs.webkit.org/show_bug.cgi?id=29187
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
PassRefPtr does not exist in Webkit Github source as of today. So this will be WONTFIX at this point. Thanks!
Alexey Proskuryakov
We still have derefIfNotNull in RefPtr though. Also in CheckedPtr.
But it has changed, and I'm not sure if there is anything to do at this point.