Summary: | Division is needlessly slow in 64-bit | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Oliver Hunt
2009-09-24 15:14:50 PDT
Created attachment 40084 [details]
Patch v1
Comment on attachment 40084 [details]
Patch v1
As I said on IRC, I think you should copy JSVALUE32_64, and convert back to int at the end in all cases other than 1/x. See JITArithmetic.cpp:992.
Variable names j1 j11 j2 j22 ain't up to scratch, let's make them a little more descriptive. Please add the runtime assert as described to the slowcase. Created attachment 40094 [details]
Patch v1
Created attachment 40095 [details]
Patch v1
|