Bug 29723

Summary: Division is needlessly slow in 64-bit
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: barraclough
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Patch v1
Patch v1
Patch v1 barraclough: review+

Description Oliver Hunt 2009-09-24 15:14:50 PDT
it needs to have real codegen
Comment 1 Oliver Hunt 2009-09-24 15:16:45 PDT
Created attachment 40084 [details]
Patch v1
Comment 2 Geoffrey Garen 2009-09-24 15:36:58 PDT
Comment on attachment 40084 [details]
Patch v1

As I said on IRC, I think you should copy JSVALUE32_64, and convert back to int at the end in all cases other than 1/x. See JITArithmetic.cpp:992.
Comment 3 Gavin Barraclough 2009-09-24 15:43:26 PDT
Variable names j1 j11 j2 j22 ain't up to scratch, let's make them a little more descriptive.
Please add the runtime assert as described to the slowcase.
Comment 4 Oliver Hunt 2009-09-24 17:24:08 PDT
Created attachment 40094 [details]
Patch v1
Comment 5 Oliver Hunt 2009-09-24 17:38:02 PDT
Created attachment 40095 [details]
Patch v1
Comment 6 Oliver Hunt 2009-09-24 19:44:37 PDT
Committed r48744