Summary: | [GTK] re-enable some media tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Philippe Normand
2009-09-24 09:10:47 PDT
Created attachment 40069 [details]
proposed patch
Created attachment 40071 [details]
proposed patch (without white spaces in ChangeLog)
Comment on attachment 40071 [details] proposed patch (without white spaces in ChangeLog) OK, a couple nits: > + [GTK] re-enable some media tests > + https://bugs.webkit.org/show_bug.cgi?id=29716 > + > + make canPlayType() return "probably" if mime-type is known > + and codecs string is not empty. If codecs is empty return > + "maybe". > + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: > + (WebCore::MediaPlayerPrivate::duration): > + This is refering to duration, but you only touch supportsType. Maybe it was incorrectly generated by prepare-ChangeLogs, but may be worth fixing. Also, I think you want a blank line between the message and the list of files. I'll ask that you upload a new patch just because I am lazy and want to use the commit bot =). Comment on attachment 40071 [details]
proposed patch (without white spaces in ChangeLog)
I will actually fix the nits myself, and land.
|