Bug 29707

Summary: Web Inspector: Color-code watch expression errors with red.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: pmuellr, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch timothy: review+, eric: commit-queue-

Description Pavel Feldman 2009-09-24 02:12:16 PDT
Reference and parse errors are currently rendered as black plain strings.
Comment 1 Pavel Feldman 2009-09-24 02:17:14 PDT
Created attachment 40054 [details]
patch
Comment 2 Patrick Mueller 2009-09-24 06:29:47 PDT
It would probably be useful to have this in ObjectProperties* bits instead of just the WatchExpressiosn.  So that if I'm in a catch block, I'll see my exception in the locals as red.  Or if I happen to have some other local variable or object property which is holding onto an exception for some reason, it would also go red.

See also: bug 27235
Comment 3 Timothy Hatcher 2009-09-24 07:25:11 PDT
Red might mean "changed" since last step, like in Xcode too. So I'm not sure this should be  universal thing for ObjectPropertiesSection.
Comment 4 Patrick Mueller 2009-09-24 07:47:23 PDT
That's fine for now.  As we implement bug 27235, maybe we'll find a better holistic approach.  

w/r/t "changed since last step", I suppose we should open a bug up on that.  So I just did, as bug 29714
Comment 5 Eric Seidel (no email) 2009-09-29 14:12:43 PDT
Comment on attachment 40054 [details]
patch

I think svn-apply would get confused by this ChangeLog, so marking cq-.  Besides Pavel is a committer. :)
Comment 6 Pavel Feldman 2009-09-29 14:24:17 PDT
Landed as r48718.