Bug 29694

Summary: WebCore side of changes to remove gfx::Rect dependency from ImageSkia
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: ImagesAssignee: Peter Kasting <pkasting>
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
patch v1 dglazkov: review+, dglazkov: commit-queue-

Description Peter Kasting 2009-09-23 14:07:06 PDT
The Chromium WebCore code should not rely on types in the Chromium repository like gfx::Rect.  This bug is for the WebCore side of a change to remove one such dependency; I also need to land a simultaneous Chromium change once this is committed.
Comment 1 Peter Kasting 2009-09-23 14:09:24 PDT
Created attachment 40016 [details]
patch v1
Comment 2 Dimitri Glazkov (Google) 2009-09-23 14:13:49 PDT
Comment on attachment 40016 [details]
patch v1

r=me, with nits:

> +        https://bugs.webkit.org/show_bug.cgi?id=29694
> +        Eliminate dependency on gfx::Rect from ImageSkia.

pls put [Chromium] in front of the description.

> -    SkIRect resizedImageRect;  // Represents the size of the resized image.
> -    resizedImageRect.set(0, 0, destRectRounded.width(), destRectRounded.height());
> +    SkIRect resizedImageRect =  // Represents the size of the resized image.
> +        { 0, 0, destRectRounded.width(), destRectRounded.height() };

This looks a bit weird, but ok.
Comment 3 Peter Kasting 2009-09-23 14:19:13 PDT
Fixed in r48684.