WebCore side of changes to remove gfx::Rect dependency from ImageSkia

• Component: Images
• Status: RESOLVED FIXED

[Peter Kasting]

The Chromium WebCore code should not rely on types in the Chromium repository like gfx::Rect.  This bug is for the WebCore side of a change to remove one such dependency; I also need to land a simultaneous Chromium change once this is committed.

[Peter Kasting]

Created attachment 40016 [details]
patch v1

[Dimitri Glazkov (Google)]

Comment on attachment 40016 [details]
patch v1

r=me, with nits:

> +        https://bugs.webkit.org/show_bug.cgi?id=29694
> +        Eliminate dependency on gfx::Rect from ImageSkia.

pls put [Chromium] in front of the description.

> -    SkIRect resizedImageRect;  // Represents the size of the resized image.
> -    resizedImageRect.set(0, 0, destRectRounded.width(), destRectRounded.height());
> +    SkIRect resizedImageRect =  // Represents the size of the resized image.
> +        { 0, 0, destRectRounded.width(), destRectRounded.height() };

This looks a bit weird, but ok.

[Peter Kasting]

Fixed in r48684.