Bug 29687

Summary: Web Inspector: Show HTTP protocol version and other Network Load Metrics (IP Address, Priority, Connection ID)
Product: WebKit Reporter: James Wheare <james>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, bweinstein, cdumez, commit-queue, dbates, inspector-bugzilla-changes, japhet, joepeck, keith_miller, koivisto, mark.lam, msaboff, sbarati, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] New Datagrid Columns
none
[IMAGE] Resources Details Sidebar
none
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix mattbaker: review+

Description James Wheare 2009-09-23 10:38:25 PDT
I'd like to see the HTTP version in the HTTP Information inspector details as implemented in http://trac.webkit.org/changeset/48646

HTTP Version is useful info because it affects resource download pipelining behaviour.

Brian Weinstein says (https://bugs.webkit.org/show_bug.cgi?id=19945#c25):
> this data is not easy to get from either a ResourceResponse or a
> ResourceRequest, so it would take some big changes, and we would need some
> information that I don't know if we have an API to get.
Comment 1 Brian Burg 2014-12-11 16:51:13 PST
Yeah, good luck getting that data. :)
Comment 2 Joseph Pecoraro 2014-12-11 16:55:12 PST
We absolutely want to ultimately show pipelining information in Web Inspector when we can get that information from the underlying network layer (different per-port). The next step is integrating the richer Network Timing information we have into Inspector.
Comment 3 Radar WebKit Bug Importer 2014-12-17 11:24:57 PST
<rdar://problem/19281586>
Comment 4 Joseph Pecoraro 2017-03-09 11:41:29 PST
We included the protocol for Resource Timing with NetworkLoadMetrics. Exposing those and a few more metrics to Web Inspector.
Comment 5 Joseph Pecoraro 2017-03-09 11:47:49 PST
Created attachment 303943 [details]
[PATCH] Proposed Fix
Comment 6 Joseph Pecoraro 2017-03-09 11:48:53 PST
Created attachment 303944 [details]
[IMAGE] New Datagrid Columns
Comment 7 Joseph Pecoraro 2017-03-09 12:08:19 PST
Comment on attachment 303943 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=303943&action=review

> Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js:57
>          columns.type.title = WebInspector.UIString("Type");
> -        columns.type.width = "6%";
> +        columns.type.width = "8%";
>  
>          columns.method.title = WebInspector.UIString("Method");
> -        columns.method.width = "5%";
> +        columns.method.width = "6%";
>  
>          columns.scheme.title = WebInspector.UIString("Scheme");
> -        columns.scheme.width = "5%";
> +        columns.scheme.width = "6%";
>  
>          columns.statusCode.title = WebInspector.UIString("Status");
> -        columns.statusCode.width = "5%";
> +        columns.statusCode.width = "6%";

Errr, all of these numbers should not have changed. I'll change them back
Comment 8 Simon Fraser (smfr) 2017-03-09 12:10:01 PST
Do we also show it when I select a specific resource, and look at the right sidebar where we show the MIME type, Location etc? That's where I'd expect to see it.
Comment 9 Joseph Pecoraro 2017-03-09 12:53:47 PST
(In reply to comment #8)
> Do we also show it when I select a specific resource, and look at the right
> sidebar where we show the MIME type, Location etc? That's where I'd expect
> to see it.

We do not, I'll add that and put up another patch.
Comment 10 Joseph Pecoraro 2017-03-09 14:13:14 PST
Created attachment 303988 [details]
[IMAGE] Resources Details Sidebar
Comment 11 Joseph Pecoraro 2017-03-09 14:13:34 PST
Created attachment 303989 [details]
[PATCH] Proposed Fix
Comment 12 Joseph Pecoraro 2017-03-09 14:15:40 PST
Comment on attachment 303989 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=303989&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:928
> +                copy[columnIdentifier] = visible;

This could be potentially improved so that if the new value is the default value we don't store anything for it. So something like:

    if (visible === !!originalColumnInfo.hidden)
        delete copy[columnIdentifier];
    else
        copy[columnIdentifier] = visible;

Let me know if you want me to try to move in that direction. I haven't checked if we have the "originalColumnInfo"
Comment 13 Joseph Pecoraro 2017-03-09 14:17:50 PST
Created attachment 303992 [details]
[PATCH] Proposed Fix
Comment 14 Joseph Pecoraro 2017-03-09 14:18:11 PST
Comment on attachment 303992 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=303992&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:928
> +                copy[columnIdentifier] = visible;

This could be potentially improved so that if the new value is the default value we don't store anything for it. So something like:

    if (visible === !!originalColumnInfo.hidden)
        delete copy[columnIdentifier];
    else
        copy[columnIdentifier] = visible;

Let me know if you want me to try to move in that direction. I haven't checked if we have the "originalColumnInfo"
Comment 15 Matt Baker 2017-03-09 14:26:18 PST
Comment on attachment 303992 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=303992&action=review

>> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:928
>> +                copy[columnIdentifier] = visible;
> 
> This could be potentially improved so that if the new value is the default value we don't store anything for it. So something like:
> 
>     if (visible === !!originalColumnInfo.hidden)
>         delete copy[columnIdentifier];
>     else
>         copy[columnIdentifier] = visible;
> 
> Let me know if you want me to try to move in that direction. I haven't checked if we have the "originalColumnInfo"

I like it. Filed follow-up:

Web Inspector: Improve storing of DataGrid column visibility
https://bugs.webkit.org/show_bug.cgi?id=169444
Comment 16 Matt Baker 2017-03-09 14:34:51 PST
Comment on attachment 303992 [details]
[PATCH] Proposed Fix

Very nice! r=me. Although the SPI/networking changes are straightforward and appear correct, someone with more knowledge in that area should maybe have a look.
Comment 17 Brian Burg 2017-03-09 15:04:29 PST
Comment on attachment 303992 [details]
[PATCH] Proposed Fix

r=me as well
Comment 18 Joseph Pecoraro 2017-03-09 15:44:57 PST
<https://trac.webkit.org/changeset/213682>
Comment 19 Joseph Pecoraro 2017-03-09 16:19:48 PST
Follow-up to avoid possible build issues regarding the SPI:
<https://trac.webkit.org/changeset/213685>

This workaround should be possible to remove shortly.