Summary: | In profiler, call tree nodes expansion doesn't respect current sorting | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, pfeldman, timothy | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Created attachment 41356 [details]
proposed patch
The patch may look big, but it's only because I swapped BottomUpProfileDataGridTree and Node declarations to be consistent with TopDownProfile.
Comment on attachment 41356 [details]
proposed patch
You should call doPopulate _sharedPopulate. Using an underscore since it is private.
Created attachment 41532 [details]
a patch to submit: renamed doPopulate -> _shouldPopulate
Ugh, the comment is wrong. I renamed doPopulate to _sharedPopulate, as Timothy proposes. Comment on attachment 41532 [details] a patch to submit: renamed doPopulate -> _shouldPopulate Clearing flags on attachment: 41532 Committed r49891: <http://trac.webkit.org/changeset/49891> All reviewed patches have been landed. Closing bug. |
Created attachment 39978 [details] Screenshot When expanding nodes of a call tree, children revealed are not sorted according to the current sorting column. To reproduce: - collect a profile; - open it and sort data, say, by the "Calls" column, observe that items shown are sorted; - now expand a node, observe that children shown are not sorted by the "Calls" column. See the attached screenshot. I'm planning to fix this issue.