|Summary:||In profiler, call tree nodes expansion doesn't respect current sorting|
|Product:||WebKit||Reporter:||Mikhail Naganov <mnaganov>|
|Component:||Web Inspector (Deprecated)||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||commit-queue, pfeldman, timothy|
|Version:||528+ (Nightly build)|
Description Mikhail Naganov 2009-09-23 01:02:06 PDT
Created attachment 39978 [details] Screenshot When expanding nodes of a call tree, children revealed are not sorted according to the current sorting column. To reproduce: - collect a profile; - open it and sort data, say, by the "Calls" column, observe that items shown are sorted; - now expand a node, observe that children shown are not sorted by the "Calls" column. See the attached screenshot. I'm planning to fix this issue.
Comment 1 Mikhail Naganov 2009-10-17 07:02:38 PDT
Created attachment 41356 [details] proposed patch The patch may look big, but it's only because I swapped BottomUpProfileDataGridTree and Node declarations to be consistent with TopDownProfile.
Comment 2 Timothy Hatcher 2009-10-20 15:29:13 PDT
Comment on attachment 41356 [details] proposed patch You should call doPopulate _sharedPopulate. Using an underscore since it is private.
Comment 3 Mikhail Naganov 2009-10-20 15:54:39 PDT
Created attachment 41532 [details] a patch to submit: renamed doPopulate -> _shouldPopulate
Comment 4 Mikhail Naganov 2009-10-20 15:58:29 PDT
Ugh, the comment is wrong. I renamed doPopulate to _sharedPopulate, as Timothy proposes.
Comment 5 WebKit Commit Bot 2009-10-20 16:10:53 PDT
Comment on attachment 41532 [details] a patch to submit: renamed doPopulate -> _shouldPopulate Clearing flags on attachment: 41532 Committed r49891: <http://trac.webkit.org/changeset/49891>
Comment 6 WebKit Commit Bot 2009-10-20 16:10:57 PDT
All reviewed patches have been landed. Closing bug.