Bug 296684
| Summary: | SharedBufferBuilder::take() should return a contiguous SharedBuffer if it only contains a single DataSegment. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | WebCore Misc. | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
When we create a SharedBufferBuilder and only append a single segment to it, if we later call SharedBufferBuilder::take() what we get is a FragmentedSharedBuffer, it could be a SharedBuffer instead.
Which would allow simplification later and remove unnecessary allocation when we then call getAsContiguous() on that SharedBuffer.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/157093750>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/48760
EWS
Committed 298168@main (a20b10db9c2d): <https://commits.webkit.org/298168@main>
Reviewed commits have been landed. Closing PR #48760 and removing active labels.