Bug 29661

Summary:

Vanilla build setup for Win32/Cairo build

Product:

WebKit

Reporter:

Marshall Culpepper <mculpepper>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
build patch	none
build patch #2	none

Marshall Culpepper

Reported 2009-09-22 17:13:00 PDT

There are a few minor problems holding back the Win32/Cairo port from building from a vanilla source tree: - Both WebCoreCairo.vsprops and WebKitLibraries/win/tools/vsprops/WinCairo.vsprops doesn't include $(WebKitLibrariesDir)/include/cairo, causing both WebKit and DumpRenderTree to fail looking for cairo.h - DumpRenderTree still looks for jpeg.lib as opposed to libjpeg.lib Once these are fixed, we should be able to build Win32/Cairo by simply extracting the necessary libs/includes into the $WebKitLibraries folder, which is where the rest of the compile dependencies live.

Attachments
build patch (6.52 KB, patch) 2009-09-22 17:18 PDT, Marshall Culpepper	no flags	Details Formatted Diff Diff
build patch #2 (7.17 KB, patch) 2009-09-22 18:45 PDT, Marshall Culpepper	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Marshall Culpepper

Comment 1 2009-09-22 17:18:30 PDT

Created attachment 39963 [details] build patch

Brent Fulgham

Comment 2 2009-09-22 17:27:03 PDT

This patch looks good to me.

Marshall Culpepper

Comment 3 2009-09-22 18:45:14 PDT

Created attachment 39973 [details] build patch #2 Looks like there's also a minor compile failure in DRT, the stub for setAlwaysAcceptCookies doesn't return anything when using cURL. Here's an updated patch.

Eric Seidel (no email)

Comment 4 2009-09-23 17:43:19 PDT

Comment on attachment 39973 [details] build patch #2 Ok. LGTM. I'm assuming you want this auto-committed since you're not a committer. In the future be sure to set commit-queue=? if you want things auto-committed (or make other arrangements to have a committer land your patch for you.) See http://webkit.org/coding/contributing.html.

WebKit Commit Bot

Comment 5 2009-09-23 17:55:06 PDT

Comment on attachment 39973 [details] build patch #2 Clearing flags on attachment: 39973 Committed r48692: <http://trac.webkit.org/changeset/48692>

WebKit Commit Bot

Comment 6 2009-09-23 17:55:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.