Bug 29660

Summary: Move "Generate 64-bit Export File" build phase script into DerivedSources.make
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1
none
Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h
mrowe: review+
Move "Generate 64-bit Export File" build phase script into DerivedSources.make mrowe: review+

Description David Kilzer (:ddkilzer) 2009-09-22 16:33:54 PDT
Created attachment 39960 [details]
Patch v1

Reviewed by NOBODY (OOPS!).

The "Generate 64-bit Export File" build phase script built the
WebKit.LP64.exp export file used to link 64-bit WebKit.  Instead
of having a separate build phase script, move its generation
into DerivedSources.make where WebCore.exp is generated.  Note
that because of VPATH usage in DerivedSources.make
WebCore.LP64.exp had to be renamed to WebCore.LP64.base.exp.

* DerivedSources.make: Added a rule to make WebCore.LP64.exp.
* WebCore.LP64.base.exp: Renamed from WebCore/WebCore.LP64.exp.
* WebCore.xcodeproj/project.pbxproj: Removed the "Generate
64-bit Export File" build phase script.
---
 5 files changed, 44 insertions(+), 37 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2009-09-22 16:37:46 PDT
(In reply to comment #0)
> The "Generate 64-bit Export File" build phase script built the
> WebKit.LP64.exp export file used to link 64-bit WebKit.  Instead

Already changed "WebKit.LP64.exp" to "WebCore.LP64.exp" and "WebKit" to "WebCore" above.
Comment 2 David Kilzer (:ddkilzer) 2009-09-22 17:18:05 PDT
Comment on attachment 39960 [details]
Patch v1

Clearing the review? flag based on comments from a private discussion with Mark.
Comment 3 David Kilzer (:ddkilzer) 2009-09-22 18:03:47 PDT
Created attachment 39969 [details]
Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h
Comment 4 David Kilzer (:ddkilzer) 2009-09-22 18:03:50 PDT
Created attachment 39970 [details]
Move "Generate 64-bit Export File" build phase script into DerivedSources.make
Comment 5 Mark Rowe (bdash) 2009-09-23 11:16:42 PDT
Comment on attachment 39969 [details]
Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h

r=me
Comment 6 Mark Rowe (bdash) 2009-09-23 11:21:43 PDT
Comment on attachment 39970 [details]
Move "Generate 64-bit Export File" build phase script into DerivedSources.make

r=me
Comment 7 David Kilzer (:ddkilzer) 2009-09-23 15:04:06 PDT
Committed r48685: <http://trac.webkit.org/changeset/48685>
Committed r48686: <http://trac.webkit.org/changeset/48686>
Comment 8 David Kilzer (:ddkilzer) 2009-09-23 19:19:23 PDT
Committed r48686: <http://trac.webkit.org/changeset/48686>