Summary: | RenderThemeChromiumWin should use true system colors for CSS system colors | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||
Component: | CSS | Assignee: | Peter Kasting <pkasting> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Peter Kasting
2009-09-22 14:17:50 PDT
Created attachment 39944 [details]
patch v1
Comment on attachment 39944 [details] patch v1 Two minor nits to fix up on landing. > Index: WebCore/rendering/RenderThemeChromiumWin.cpp > =================================================================== > +// Map a CSSValue* system color to an index understood by GetSysColor Please add a period to the end of the sentence. > +static int cssValueIdToSysColorIndex(int cssValueId) > +{ > + switch (cssValueId) { > + case CSSValueActiveborder: return COLOR_ACTIVEBORDER; A case label should line up with its switch statement (see http://webkit.org/coding/coding-style.html) Comment on attachment 39944 [details]
patch v1
Looks sane to me too. Dave just beat me!
|