Bug 29625

Summary:

Refactor media layout tests based on codec support

Product:

WebKit

Reporter:

Andrew Scherkus <scherkus>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
First round + fixes + remaining tests	none

Andrew Scherkus

Reported 2009-09-21 17:57:01 PDT

Media layout tests now use canPlayType() to choose test files.

Attachments
First round + fixes + remaining tests (18.66 KB, patch) 2009-09-21 19:04 PDT, Andrew Scherkus	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Scherkus

Comment 1 2009-09-21 19:04:19 PDT

Created attachment 39901 [details] First round + fixes + remaining tests Since https://bugs.webkit.org/show_bug.cgi?id=28327 was fixed, I addressed your comments for my first round of layout test updates as well as included the last of the tests still needing to be converted.

Eric Carlson

Comment 2 2009-09-22 09:00:09 PDT

Comment on attachment 39901 [details] First round + fixes + remaining tests r=me

Eric Seidel (no email)

Comment 3 2009-09-23 18:03:52 PDT

Comment on attachment 39901 [details] First round + fixes + remaining tests Andrew is not a committer according to: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py so I assume he wants this committed given no indication otherwise.

Andrew Scherkus

Comment 4 2009-09-23 18:05:12 PDT

Yes, yes I do :) Thanks Eric(s)!

WebKit Commit Bot

Comment 5 2009-09-23 18:20:52 PDT

Comment on attachment 39901 [details] First round + fixes + remaining tests Clearing flags on attachment: 39901 Committed r48694: <http://trac.webkit.org/changeset/48694>

WebKit Commit Bot

Comment 6 2009-09-23 18:20:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.