Bug 29625 - Refactor media layout tests based on codec support
Summary: Refactor media layout tests based on codec support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-21 17:57 PDT by Andrew Scherkus
Modified: 2009-09-23 18:20 PDT (History)
1 user (show)

See Also:


Attachments
First round + fixes + remaining tests (18.66 KB, patch)
2009-09-21 19:04 PDT, Andrew Scherkus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2009-09-21 17:57:01 PDT
Media layout tests now use canPlayType() to choose test files.
Comment 1 Andrew Scherkus 2009-09-21 19:04:19 PDT
Created attachment 39901 [details]
First round + fixes + remaining tests

Since https://bugs.webkit.org/show_bug.cgi?id=28327 was fixed, I addressed your comments for my first round of layout test updates as well as included the last of the tests still needing to be converted.
Comment 2 Eric Carlson 2009-09-22 09:00:09 PDT
Comment on attachment 39901 [details]
First round + fixes + remaining tests

r=me
Comment 3 Eric Seidel (no email) 2009-09-23 18:03:52 PDT
Comment on attachment 39901 [details]
First round + fixes + remaining tests

Andrew is not a committer according to: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py so I assume he wants this committed given no indication otherwise.
Comment 4 Andrew Scherkus 2009-09-23 18:05:12 PDT
Yes, yes I do :)

Thanks Eric(s)!
Comment 5 WebKit Commit Bot 2009-09-23 18:20:52 PDT
Comment on attachment 39901 [details]
First round + fixes + remaining tests

Clearing flags on attachment: 39901

Committed r48694: <http://trac.webkit.org/changeset/48694>
Comment 6 WebKit Commit Bot 2009-09-23 18:20:56 PDT
All reviewed patches have been landed.  Closing bug.