Bug 29623 – Media test files in Ogg and Theora formats

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Hin-Chung Lam]

Provide Ogg and Theora formatted test files.

[Hin-Chung Lam]

Created attachment 39896 [details]
Test files for ogg and theora, transcoded from originals

[Hin-Chung Lam]

Created attachment 39897 [details]
Test files for ogg and theora, transcoded from originals

[Hin-Chung Lam]

Created attachment 39898 [details]
Test files for ogg and theora, transcoded from originals

[Eric Seidel (no email)]

Seems fine to me, although Eric would be the best person to rubber stamp this.

[Eric Carlson]

Comment on attachment 39898 [details]
Test files for ogg and theora, transcoded from originals

r(ubberstamp) = me

[WebKit Commit Bot]

Comment on attachment 39898 [details]
Test files for ogg and theora, transcoded from originals

Rejecting patch 39898 from commit-queue.

Patch https://bugs.webkit.org/attachment.cgi?id=39898 from bug 29623 failed to download and apply.

[Eric Seidel (no email)]

patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patch: **** Only garbage was found in the patch input.
patching file LayoutTests/media/content/garbage.ogv
error: pathspec 'LayoutTests/media/content/counting.ogv' did not match any file(s) known to git.
Did you forget to 'git add'?
error: pathspec 'LayoutTests/media/content/silence.oga' did not match any file(s) known to git.
Did you forget to 'git add'?
error: pathspec 'LayoutTests/media/content/test.oga' did not match any file(s) known to git.
Did you forget to 'git add'?
error: pathspec 'LayoutTests/media/content/test.ogv' did not match any file(s) known to git.
Did you forget to 'git add'?

I think this is known trouble with svn-apply and git patches.  I'm not sure though.

[Eric Seidel (no email)]

This looks like the same failures as bug 29100, but I just fixed that, so I'm not sure.  Maybe I didn't fix it right.

[Hin-Chung Lam]

I generate the patch using svn-create-patch but not git, would this be the reason?

[Eric Carlson]

The problem was with the entry for empty.oga:

Index: LayoutTests/media/content/empty.oga
===================================================================

patch apparently can't handle a completely empty file. I removed that line from the patch, applied it locally, created the empty.oga manually, and added it to svn and all was fine.

http://trac.webkit.org/changeset/48667

[Eric Seidel (no email)]

(In reply to comment #10)
> The problem was with the entry for empty.oga:
> 
> Index: LayoutTests/media/content/empty.oga
> ===================================================================
> 
> patch apparently can't handle a completely empty file. I removed that line from
> the patch, applied it locally, created the empty.oga manually, and added it to
> svn and all was fine.
> 
> http://trac.webkit.org/changeset/48667

Seems like we'll need to file a bug about that.  svn-apply should be able to handle such.

[Eric Carlson]

Filed https://bugs.webkit.org/show_bug.cgi?id=29684

[Hin-Chung Lam]

Thanks for the review and landing this for me!