Summary: | Incorrect Win baseline for Layout test fast/canvas/toDataURL-supportedTypes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Victor Wang <victorw> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, sam, victorw | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows Vista | ||||||
Attachments: |
|
Description
Victor Wang
2009-09-21 15:38:47 PDT
Created attachment 39998 [details]
Proposed patch
I think the win baseline for this test could be removed.
Comment on attachment 39998 [details]
Proposed patch
Nice find! We should wait a bit to give Sam a chance to speak up if there's something subtle here.
Everything looks good here. r=me as well. Comment on attachment 39998 [details]
Proposed patch
Victor is not a committer, so adding cq+.
Comment on attachment 39998 [details] Proposed patch Rejecting patch 39998 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39998 from bug 29619 failed to download and apply. patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/win/Skipped patching file LayoutTests/platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt rm 'LayoutTests/platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt' Could not open 'LayoutTests/platform/win/fast/canvas' to list files: 0 at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 358, <> line 99. That's a new one. It might be an error in svn-apply, not sure. Reviewed patches have been landed. Closing bug |