Bug 296166
| Summary: | Use std::unique_ptr instead of MallocPtr in ConcurrentBuffer and SegmentedVector | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vassili Bykov <v_bykov> |
| Component: | Web Template Framework | Assignee: | Vassili Bykov <v_bykov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vassili Bykov
We are about to harden MallocPtr by requiring the parameter type to be trivially destructible. That will prevent accidentally introduced memory leaks, when a type is used with MallocPtr under the assumption it does not need a destructor call, but is later changed to require non-trivial destruction (https://bugs.webkit.org/show_bug.cgi?id=294022).
Two recently merged PRs introduce uses of MallocPtr incompatible with this upcoming change:
https://github.com/WebKit/WebKit/pull/47965
https://github.com/WebKit/WebKit/pull/48000
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/156121020>
Vassili Bykov
Pull request: https://github.com/WebKit/WebKit/pull/48227
EWS
Committed 297601@main (002b94dcc58e): <https://commits.webkit.org/297601@main>
Reviewed commits have been landed. Closing PR #48227 and removing active labels.