Bug 29582

Summary: REGRESSION: [Chromium] drop down selects fail to close when a value is selected
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch dglazkov: review+

Description Darin Fisher (:fishd, Google) 2009-09-21 08:47:25 PDT 
REGRESSION: [Chromium] drop down selects fail to close when a value
is selected

This is a regression from http://trac.webkit.org/changeset/48370

The change to RenderMenuList.cpp causes PopupMenu::hide() to no
longer be called.  It looks like the Chromium implementation was a
bit different than the other ports in its dependency on this.
Comment 1 Darin Fisher (:fishd, Google) 2009-09-21 08:58:49 PDT 
Created attachment 39854 [details]
v1 patch
Comment 2 Dimitri Glazkov (Google) 2009-09-21 09:01:04 PDT 
Comment on attachment 39854 [details]
v1 patch

r=me.

>      // Hides the popup.  Do not call this directly: use client->hidePopup().
This ain't true no more.
Comment 3 Darin Fisher (:fishd, Google) 2009-09-21 09:07:14 PDT 
Landed as http://trac.webkit.org/changeset/48585