Bug 295712
| Summary: | [ews] Rename pr_id to pr_number | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | New Bugs | Assignee: | Aakash Jain <aakash_jain> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Aakash Jain
In ews-app (and ews-build) we used two different variable names `pr_id` and `pr_number` in various places to refer to one thing, GitHub PR number. We should consolidate to use a single one.
`pr_number` is more appropriate variable name for this, since it's not a unique id, and GitHub also refers to it as PR number in its documentation/API.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/47828
Radar WebKit Bug Importer
<rdar://problem/155537356>
EWS
Committed 297396@main (967fe34df0a8): <https://commits.webkit.org/297396@main>
Reviewed commits have been landed. Closing PR #47828 and removing active labels.