Bug 295282
| Summary: | [webkitpy] List 'websocket' as a first class AutoInstall package | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | Tools / Tests | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
In 288959@main we added a custom Selenium import finder so `run-webdriver-tests` can use the imported selenium version instead of the autoinstalled selenium in `webkitpy` used in other scripts.
But, on a clean tree with no autoinstalled packages, the client `websocket` package is not installed, as it's an implicit dependency of selenium. It leads to errors like:
./Tools/Scripts/run-webdriver-tests --verbose --release --wpe --display-server=headless "imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py"
<snip>
ImportError while loading conftest '/app/webkit/WebDriverTests/imported/selenium/py/conftest.py'.
/app/webkit/WebDriverTests/imported/selenium/py/conftest.py:29: in <module>
from selenium import webdriver
/app/webkit/WebDriverTests/imported/selenium/py/selenium/webdriver/__init__.py:22: in <module>
from .remote.webdriver import WebDriver as Remote # noqa
/app/webkit/WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webdriver.py:74: in <module>
from .websocket_connection import WebSocketConnection
/app/webkit/WebDriverTests/imported/selenium/py/selenium/webdriver/remote/websocket_connection.py:23: in <module>
from websocket import WebSocketApp # type: ignore
E ModuleNotFoundError: No module named 'websocket'
webkitpy.webdriver_tests.webdriver_test_runner: [INFO] No tests found
webkitpy.webdriver_tests.webdriver_test_runner: [INFO]
webkitpy.webdriver_tests.webdriver_test_runner: [INFO] All tests run as expected
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/47442
EWS
Committed 296892@main (4d779636fffb): <https://commits.webkit.org/296892@main>
Reviewed commits have been landed. Closing PR #47442 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/154806447>