Bug 29524

Summary: Implement ES5 Object.create function
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: erikcorry
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 mjs: review+

Description Oliver Hunt 2009-09-19 17:54:06 PDT
As above
rdar://7214113
Comment 1 Oliver Hunt 2009-09-19 17:57:21 PDT
Created attachment 39829 [details]
Patch v1
Comment 2 Maciej Stachowiak 2009-09-19 18:08:50 PDT
Comment on attachment 39829 [details]
Patch v1

r=me
Comment 3 Oliver Hunt 2009-09-19 18:14:47 PDT
Committed r48568
Comment 4 Erik Corry 2009-12-07 03:59:52 PST
Doesn't seem to work reliably.  The following causes a crash:

function valueGet() { };
var MagicValueProps = { foo: Object.create(null, { value: { get: valueGet }})};
Object.create(null, MagicValueProps)
Comment 5 Oliver Hunt 2009-12-07 05:29:21 PST
This should not have been reopened -- a new bug should have been filed.