Bug 29503

Summary: Implement ES5 Object.defineProperty function
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Implement ES5 Object.defineProperty function ggaren: review+

Oliver Hunt
Reported 2009-09-18 13:54:01 PDT
as in title
Attachments
Implement ES5 Object.defineProperty function (87.91 KB, patch)
2009-09-18 14:51 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-09-18 13:54:50 PDT
rdar://7214220
Oliver Hunt
Comment 2 2009-09-18 14:51:48 PDT
Created attachment 39791 [details] Implement ES5 Object.defineProperty function https://bugs.webkit.org/show_bug.cgi?id=29503 Reviewed by NOBODY(OOPS!) Implement Object.defineProperty. This requires adding the API to ObjectConstructor, along with a helper function that implements the ES5 internal [[ToPropertyDescriptor]] function. It then adds JSObject::defineOwnProperty that implements the appropriate ES5 semantics. Currently defineOwnProperty uses a delete followed by a put to redefine attributes of a property, clearly this is less efficient than it could be but we can improve this if it needs to be possible in future. --- 33 files changed, 921 insertions(+), 73 deletions(-)
Geoffrey Garen
Comment 3 2009-09-18 15:27:39 PDT
Comment on attachment 39791 [details] Implement ES5 Object.defineProperty function r=me
Oliver Hunt
Comment 4 2009-09-18 16:12:22 PDT
Committed r48542
Note You need to log in before you can comment on or make changes to this bug.