Bug 29499

Summary: Coding style guidelines should standardize on "using namespace" positioning
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit WebsiteAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed guidelines darin: review+

Brady Eidson
Reported 2009-09-18 11:38:39 PDT
"using namespace" statements are positions in a very inconsistent manner throughout WebCore - sometimes before a defined namespace, and sometimes within that defined namespace. The coding style guidelines should specify a standard place to put these.
Attachments
Proposed guidelines (1.83 KB, patch)
2009-09-18 11:39 PDT, Brady Eidson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2009-09-18 11:39:56 PDT
Created attachment 39771 [details] Proposed guidelines
Darin Adler
Comment 2 2009-09-18 11:49:48 PDT
I like this guideline, but I think we should have a brief webkit-dev discussion before landing the change.
Brady Eidson
Comment 3 2009-09-18 12:07:40 PDT
Agreed, I will send an email out
Brady Eidson
Comment 4 2009-09-21 17:14:31 PDT
This proposal hasn't received any objections, so I'd like to land it.
Darin Adler
Comment 5 2009-09-21 18:28:38 PDT
I noticed a double period ".." somewhere in this patch. You should fix that when landing.
Eric Seidel (no email)
Comment 6 2009-09-21 18:43:04 PDT
Agreed, I think this is a great thing to put in the style guide. :)
Brady Eidson
Comment 7 2009-09-21 19:16:56 PDT
Committed rr48616: <http://trac.webkit.org/changeset/r48616>
Brady Eidson
Comment 8 2009-09-21 19:17:42 PDT
`bugzilla-tool mark-fixed` beats me again... Committed r48616: <http://trac.webkit.org/changeset/48616>
Note You need to log in before you can comment on or make changes to this bug.