Bug 29494

Summary:

HTMLMediaElement m_playedTimeRanges can be NULL

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebCore Misc.

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	darin: review+

Eric Carlson

Reported 2009-09-18 10:15:01 PDT

m_playedTimeRanges is initialized in HTMLMediaElement::loadInternal and assumed to be non-NULL everywhere it is used. This does not work when PLUGIN_PROXY_FOR_VIDEO is defined, because loadInternal is never called.

Attachments
proposed patch (3.71 KB, patch) 2009-09-18 10:28 PDT, Eric Carlson	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2009-09-18 10:28:08 PDT

Created attachment 39767 [details] proposed patch

Darin Adler

Comment 2 2009-09-18 10:36:58 PDT

Comment on attachment 39767 [details] proposed patch Can we have a regression test for this?

Eric Carlson

Comment 3 2009-09-18 11:47:52 PDT

A regression test isn't possible on the desktop because none of the ports build with PLUGIN_PROXY_FOR_VIDEO defined.

Eric Carlson

Comment 4 2009-09-18 11:48:09 PDT

http://trac.webkit.org/changeset/48519

Note You need to log in before you can comment on or make changes to this bug.