Bug 294041
| Summary: | [Style] Use strong Style value types for size types width, height, min-width, min-height, max-width, max-height, and flex-basis | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jenner, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
Add wrappers (for now) of WebCore::Length for the size types width, height, min-width, min-height, max-width, max-height, and flex-basis.
This will allow us to enforce at the type level which keywords and value ranges are supported for each type and make the code a bit more clear.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/46336
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/46476
EWS
Committed 296045@main (4bf6d54fbdaf): <https://commits.webkit.org/296045@main>
Reviewed commits have been landed. Closing PR #46476 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/152975426>
Robert Jenner
Reopened Bugzilla.
[Style] Use strong Style value types for size types width, height, min-width, min-height, max-width, max-height, and flex-basis, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=294041.
EWS
Committed 296049@main (3f246c674828): <https://commits.webkit.org/296049@main>
Reviewed commits have been landed. Closing PR #46558 and removing active labels.
Robert Jenner
https://commits.webkit.org/296045@main broke all apple builds. We had to revert it. Please hold, as we are upstreaming changes shortly to prep for re-landing this.
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/46665
EWS
Committed 296172@main (eedb96ae03e8): <https://commits.webkit.org/296172@main>
Reviewed commits have been landed. Closing PR #46665 and removing active labels.
Sam Weinig
*** Bug 286245 has been marked as a duplicate of this bug. ***