Bug 293978
| Summary: | Replace hard coded @"NSErrorFailingURLKey" in favor of the framework NSURLErrorFailingURLErrorKey symbol | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
WebKit hardcoded the string value @"NSErrorFailingURLKey" in many places, probably before Foundation standardized on the `NSURLErrorFailingURLErrorKey` symbol in macOS 10.6 (and iOS 4.0).
We should use this framework symbol rather than the string value.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/152520483>
Brent Fulgham
Note: `NSURLErrorFailingURLErrorKey` is defined as @"NSErrorFailingURLKey".
Brent Fulgham
The deprecated `NSURLErrorFailingURLStringErrorKey` symbol is defined as @"NSErrorFailingURLStringKey".
We should probably remove its use in a future patch.
Brent Fulgham
PR: https://github.com/WebKit/WebKit/pull/46280
EWS
Committed 295919@main (174717c86b54): <https://commits.webkit.org/295919@main>
Reviewed commits have been landed. Closing PR #46280 and removing active labels.