Summary: | [Qt] QtWebKit: ESC key does not clear the text of the line edit when canceling an input method | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tor Arne Vestbø <vestbo> | ||||||
Component: | Forms | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | ap, commit-queue, eric, jberlin, jhanssen, jturcotte | ||||||
Priority: | P3 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Tor Arne Vestbø
2009-09-18 07:15:20 PDT
Reproduced on Windows 7 IME with Qt 4.7 and WebKit r55520 I'm setting the priority by guessing to P3, I don't use IME often so if somebody confirms that this can be annoying we can reevaluate the priority. Created attachment 76926 [details]
Patch
The problem is that the composition text is never cleared while it should be when the editor is in composition mode and an empty QInputMethodEvent is received
Can a regression test be added for this? We have some ways to simulate input method behavior in DumpRenderTree, although I don't know if those work with Qt. Created attachment 77250 [details]
Patch
Change the Qt test case to a generic one
Comment on attachment 77250 [details]
Patch
Thanks for making a nice regression test!
Comment on attachment 77250 [details] Patch Clearing flags on attachment: 77250 Committed r74605: <http://trac.webkit.org/changeset/74605> All reviewed patches have been landed. Closing bug. The new test should also have been added to the skip list for Windows, since DRT's textInputController is unimplemented on Windows: https://bugs.webkit.org/show_bug.cgi?id=32021 I will land the change to the windows skip list shortly. Committed the change to the Windows Skip list in r74641: http://trac.webkit.org/changeset/74641 Chromium is fixing their port to match this test in bug 51693. |