Bug 293630

Summary: ClientCertificateAuthenticationXPCConstants.cpp is missing include of ASCIILiteral.h
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

David Kilzer (:ddkilzer)
Reported 2025-05-27 12:20:45 PDT
Summary: Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp is missing `#include <wtf/text/ASCIILiteral.h>` for some build configurations. ``` [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource65.cpp:1: [stdout] 25-05-27 09:26:41 OpenSource/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp:35:55: error: no matching literal operator for call to 'operator""_s' with arguments of types 'const char *' and 'unsigned long', and no matching literal operator template [stdout] 25-05-27 09:26:41 35 | const ASCIILiteral XPCCertificatesKey = "certificates"_s; [stdout] 25-05-27 09:26:41 | ^ [stdout] 25-05-27 09:26:41 OpenSource/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp:35:20: error: variable has incomplete type 'const ASCIILiteral' [stdout] 25-05-27 09:26:41 35 | const ASCIILiteral XPCCertificatesKey = "certificates"_s; [stdout] 25-05-27 09:26:41 | ^ [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource65.cpp:1: [stdout] 25-05-27 09:26:41 In file included from OpenSource/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp:26: [stdout] 25-05-27 09:26:41 In file included from OpenSource/Source/WebKit/config.h:41: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/FastMalloc.h:26: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/MallocCommon.h:29: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/StdLibExtras.h:50: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/TypeTraits.h:34: [stdout] 25-05-27 09:26:41 OpenSource/WebKitBuild/Release/usr/local/include/wtf/Forward.h:36:7: note: forward declaration of 'WTF::ASCIILiteral' [stdout] 25-05-27 09:26:41 36 | class ASCIILiteral; [stdout] 25-05-27 09:26:41 | ^ ```
Attachments
Radar WebKit Bug Importer
Comment 1 2025-05-27 12:21:05 PDT
David Kilzer (:ddkilzer)
Comment 2 2025-05-27 12:23:06 PDT
EWS
Comment 3 2025-05-27 12:35:03 PDT
Committed 295456@main (2540bba1c240): <https://commits.webkit.org/295456@main> Reviewed commits have been landed. Closing PR #45955 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.