Bug 29345

Summary: The test tst_QWebFrame::popupFocus() depends on the computer's speed
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Benjamin Poulain
Reported 2009-09-17 13:41:51 PDT
The test tst_QWebFrame::popupFocus() fails on slow computers because the focus is not yet set when the value is tested. QTRY_COMPARE should be used instead of QCOMPARE when the event loop is involved.
Attachments
proposed patch (4.76 KB, patch)
2009-09-17 13:52 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2009-09-17 13:52:19 PDT
Created attachment 39722 [details] proposed patch
Simon Hausmann
Comment 2 2009-09-19 04:04:01 PDT
Comment on attachment 39722 [details] proposed patch r=me
WebKit Commit Bot
Comment 3 2009-09-19 11:08:10 PDT
Comment on attachment 39722 [details] proposed patch Rejecting patch 39722 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11284 test cases. http/tests/xmlhttprequest/cross-origin-no-authorization.html -> failed Exiting early after 1 failures. 8923 tests run. 255.73s total testing time 8922 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 4 2009-09-19 11:11:50 PDT
Comment on attachment 39722 [details] proposed patch I believe that's just a flakey test. bug 29322. Sorry for the slow feedback, the commit-queue was paused for the last 17 hours due to red builders. http://webkit-commit-queue.appspot.com/
WebKit Commit Bot
Comment 5 2009-09-19 11:22:35 PDT
Comment on attachment 39722 [details] proposed patch Clearing flags on attachment: 39722 Committed r48561: <http://trac.webkit.org/changeset/48561>
WebKit Commit Bot
Comment 6 2009-09-19 11:22:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.