Bug 29334

Summary: Add LayoutTests to test proper security checks for the cases when prototype of top window is set to child window
Product: WebKit Reporter: anton muhin <antonm>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
First pass
none
ChangeLog updated none

Description anton muhin 2009-09-17 09:48:43 PDT 
Adding some more Layout test which verify that fiddling with top window prototype doesn't lead to security troubles.

Sorry, not ideal component---best I could think of.
Comment 1 anton muhin 2009-09-17 09:53:28 PDT 
Created attachment 39699 [details]
First pass
Comment 2 anton muhin 2009-09-17 09:55:37 PDT 
Created attachment 39700 [details]
ChangeLog updated
Comment 3 Adam Barth 2009-09-17 10:01:17 PDT 
Comment on attachment 39700 [details]
ChangeLog updated

The names of the tests are not ideal because they don't say anything about about globals or __proto__, but I don't think that matters very much.
Comment 4 WebKit Commit Bot 2009-09-17 12:22:52 PDT 
Comment on attachment 39700 [details]
ChangeLog updated

Rejecting patch 39700 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
Comment 5 Eric Seidel (no email) 2009-09-17 12:24:59 PDT 
Comment on attachment 39700 [details]
ChangeLog updated

You were bitten by bug 28316, which I'm working on fixing this week. Sorry. :(
Comment 6 WebKit Commit Bot 2009-09-17 12:43:56 PDT 
Comment on attachment 39700 [details]
ChangeLog updated

Clearing flags on attachment: 39700

Committed r48484: <http://trac.webkit.org/changeset/48484>
Comment 7 WebKit Commit Bot 2009-09-17 12:44:00 PDT 
All reviewed patches have been landed.  Closing bug.