Bug 29320

Summary:

JS callback objects should store the global object

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	andersca: review+

Sam Weinig

Reported 2009-09-16 16:37:04 PDT

JS callback objects (position, database) should store the global object instead of the frame.

Attachments
patch (41.75 KB, patch) 2009-09-16 20:00 PDT, Sam Weinig	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2009-09-16 20:00:13 PDT

Created attachment 39678 [details] patch This patch changes the callbacks to store a global object instead of the Frame and removes some unnecessary script()->isEnabled() checks. I will do a follow up which changes the global object to use the 'current' one.

Anders Carlsson

Comment 2 2009-09-16 20:11:39 PDT

Comment on attachment 39678 [details] patch r=me

Sam Weinig

Comment 3 2009-09-16 20:43:05 PDT

Landed in r48453 with slight tweaks.

Adam Barth

Comment 4 2009-09-17 13:29:34 PDT

Why exec->dynamicGlobalObject() some times and exec->lexicalGlobalObject() other times? Also, this patch doesn't have tests...

Alexey Proskuryakov

Comment 5 2009-09-18 11:57:27 PDT

Yeah, this definitely needs tests...

Note You need to log in before you can comment on or make changes to this bug.