Bug 293190
| Summary: | HashTable doesn't need `ShouldValidateKey` as template parameter for the whole class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
HashTable doesn't need `ShouldValidateKey` as template parameter for the whole class. Instead, only add this template parameter for HashTable functions that actually need it. This reduces unnecessary code duplication, reduces binary size in WebCore by 1MB and avoids redundant key validations since we can now be more fine-grained.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/45555
EWS
Committed 295078@main (a8416d2c6a3b): <https://commits.webkit.org/295078@main>
Reviewed commits have been landed. Closing PR #45555 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/151562991>