| Summary: | Update contributing.html to mention recently added tools. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Seidel (no email)
2009-09-16 15:47:00 PDT
Created attachment 39664 [details]
Patch v1
Comment on attachment 39664 [details] Patch v1 > - <li>Upload the patch for review. In Bugzilla, be sure to set the <tt>review:?</tt> flag.</li> > + <li>Upload the patch for review. In Bugzilla, be sure to mark your file as a patch and set the <tt>review:?</tt> flag.</li> I think this could be slightly more explicit; it may not be obvious there is a check box labeled "patch" they have to check. But I don't have better wording to suggest. Comment on attachment 39664 [details]
Patch v1
Agreed. We could further improve the patch checkbox wording. Ideally we could just get rid of that checkbox all together. :)
I think for now I'll commit this as is and we can iterate from here. Thanks for the review!
I'll mark this cq+. The queue is off for the moment as Mark has been performing builder maintenance this evening. This will land tomorrow morning when I turn the queue back on.
Comment on attachment 39664 [details] Patch v1 Clearing flags on attachment: 39664 Committed r48488: <http://trac.webkit.org/changeset/48488> All reviewed patches have been landed. Closing bug. |