Bug 29311

Summary: webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, eric: commit-queue+

Eric Seidel (no email)
Reported 2009-09-16 13:54:01 PDT
bugzilla-tool should notice if it breaks builders bugzilla-tool could remember which commits it made, and looking at the buildbot output determine if one of its commits broke a builder, and if so email the responsible parties. It might be easier to make buildbot smarter about who it emails instead. With such information it could also just roll out its patch instead of emailing people, but that's a bit scarier at the moment since "bugzilla-tool rollout" is not quite idiot proof yet.
Attachments
Patch (9.36 KB, patch)
2010-03-26 16:46 PDT, Eric Seidel (no email) 		abarth: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-03-26 16:46:53 PDT
Created attachment 51796 [details] Patch
Adam Barth
Comment 2 2010-03-29 09:58:58 PDT
Comment on attachment 51796 [details] Patch Ok, but we should have some facility for closing these bugs automatically when the tree goes green.
Eric Seidel (no email)
Comment 3 2010-03-29 10:11:26 PDT
OK. I'll do that in a follow-up patch. Be advised, since you're currently running the Sheriff Bot, I've not live-tested these changes and there may be a typo which will require a follow-up commit.
Eric Seidel (no email)
Comment 4 2010-03-29 11:39:42 PDT
Attachment 51796 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Eric Seidel (no email)
Comment 5 2010-03-29 13:40:30 PDT
Committed r56737: <http://trac.webkit.org/changeset/56737>
Note You need to log in before you can comment on or make changes to this bug.