Bug 29308

Summary: Fix GCC warnings on ARM_THUMB2 platform
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Fix GCC warnings on ARM_THUMB2 platform none

Gabor Loki
Reported 2009-09-16 12:43:07 PDT
There are some GCC warnings when compiling ARM_THUMB2 platform on Linux. I am going to attach a patch to fix those warnings. Although this has something to do with bug 29273, it is a separate patch without any dependence.
Attachments
Fix GCC warnings on ARM_THUMB2 platform (2.56 KB, patch)
2009-09-16 12:44 PDT, Gabor Loki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2009-09-16 12:44:21 PDT
Created attachment 39658 [details] Fix GCC warnings on ARM_THUMB2 platform
WebKit Commit Bot
Comment 2 2009-09-16 16:04:19 PDT
Comment on attachment 39658 [details] Fix GCC warnings on ARM_THUMB2 platform Rejecting patch 39658 from commit-queue. ('WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1') Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11265 test cases. media/video-source-error.html -> timed out Sampling process 52487 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 52487 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 9110 tests run. 464.79s total testing time 9109 test cases (99%) succeeded 1 test case (<1%) timed out 5 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 3 2009-09-16 16:05:27 PDT
Comment on attachment 39658 [details] Fix GCC warnings on ARM_THUMB2 platform Bitten by bug 28845. :(
WebKit Commit Bot
Comment 4 2009-09-16 16:23:07 PDT
Comment on attachment 39658 [details] Fix GCC warnings on ARM_THUMB2 platform Clearing flags on attachment: 39658 Committed r48445: <http://trac.webkit.org/changeset/48445>
WebKit Commit Bot
Comment 5 2009-09-16 16:23:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.