Bug 29267 – Need a way to replace a plug-in with a substitute image

• Component: Plug-ins
• Status: RESOLVED INVALID

[Jon Honeycutt]

Created attachment 39588 [details]
Patch

We would like to have a way to replace a plug-in with a substitute image.

[Simon Fraser (smfr)]

Comment on attachment 39588 [details]
Patch

> diff --git a/WebCore/rendering/RenderObject.h b/WebCore/rendering/RenderObject.h
> index 0a3473c..c4fae6f 100644
> --- a/WebCore/rendering/RenderObject.h
> +++ b/WebCore/rendering/RenderObject.h
> @@ -738,6 +738,8 @@ public:
>          return outlineBoundsForRepaint(0);
>      }
>  
> +    virtual bool showSubstituteImage(PassRefPtr<Image>) { return false; }

This seems wrong. Why does RenderObject need to expose this? Also, it should be a const method.

[Jon Honeycutt]

(In reply to comment #1)
> (From update of attachment 39588 [details])
> >  
> > +    virtual bool showSubstituteImage(PassRefPtr<Image>) { return false; }
> 
> This seems wrong. Why does RenderObject need to expose this? Also, it should be
> a const method.

Well, RenderWidget is the only class that overrides this, but I think it's better to have this on RenderObject and let subclasses override it than to have WebKit's DOMElement be aware of the different RenderObject subclasses.

[Simon Fraser (smfr)]

But showSubstituteImage() doesn't make sense for most RenderObjects.

[Jon Honeycutt]

Obsoleted by r49060.