Bug 292342

Summary: [repaint] Changing text-decoration-color on the block has no affect on inline content when it is completely wrapped inside an inline box
Product: WebKit Reporter: alan <zalan>
Component: New BugsAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=292078
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch
none
[fast-cq]Patch none

alan
Reported 2025-04-30 12:58:22 PDT
ssia
Attachments
Patch (4.72 KB, patch)
2025-04-30 13:07 PDT, alan
no flags
Patch (4.72 KB, patch)
2025-04-30 13:57 PDT, alan
no flags
[fast-cq]Patch (5.11 KB, patch)
2025-05-01 09:39 PDT, alan
no flags
[fast-cq]Patch (5.11 KB, patch)
2025-05-01 13:03 PDT, alan
no flags
alan
Comment 1 2025-04-30 13:07:05 PDT
alan
Comment 2 2025-04-30 13:57:08 PDT
Antti Koivisto
Comment 3 2025-05-01 04:56:14 PDT
Comment on attachment 475097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=475097&action=review > Source/WebCore/rendering/RenderElement.cpp:350 > + for (auto& child : childrenOfType<RenderObject>(renderer)) { > + if (auto* textRenderer = dynamicDowncast<RenderText>(child); textRenderer && !textRenderer->containsOnlyCollapsibleWhitespace()) > + return true; > + if (auto* inlineBoxRenderer = dynamicDowncast<RenderInline>(child); inlineBoxRenderer && hasNonWhitespaceTextContent(*inlineBoxRenderer)) > + return true; > + } Could this use InlineWalker instead of recursing?
alan
Comment 4 2025-05-01 08:57:58 PDT
InlineWalker, yes please!
alan
Comment 5 2025-05-01 09:39:44 PDT
Created attachment 475104 [details] [fast-cq]Patch
EWS
Comment 6 2025-05-01 12:20:12 PDT
Commit message contains (OOPS!) and no valid reviewer found, blocking PR #None. Details: [Build #2318](https://ews-build.webkit.org/#/builders/27/builds/2318)
alan
Comment 7 2025-05-01 13:03:31 PDT
Created attachment 475108 [details] [fast-cq]Patch
EWS
Comment 8 2025-05-01 16:42:08 PDT
Committed 294403@main (005636013267): <https://commits.webkit.org/294403@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 475108 [details].
Radar WebKit Bug Importer
Comment 9 2025-05-01 16:43:23 PDT
Note You need to log in before you can comment on or make changes to this bug.