Bug 29229
Summary: | We should remove the watchdog timer from DumpRenderTree | ||
---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wilson <atwilson> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | eric, jmalonzo, rniwa |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 | ||
Bug Depends on: | 74649, 76612 | ||
Bug Blocks: |
Andrew Wilson
There's already a watchdog timer in run-webkit-tests - having a watchdog timer in DumpRenderTree itself makes it difficult to adjust timeout values via command line flags, or introduce longer timeouts when running valgrind/GuardMalloc.
We should remove the watchdog timer in DumpRenderTree, and have the watchdog timer in run-webkit-tests signal DumpRenderTree to force a notifyDone() (perhaps by writing something to STDIN, or sending a signal, or some other mechanism).
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
See bug 74649 or bug 76612 for a disable option.