Bug 292177
| Summary: | [clang][glib] Unreviewed revert of LIFETIME_BOUND in GRefPtr.get() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alicia Boya García <aboya> |
| Component: | WebKitGTK | Assignee: | Alicia Boya García <aboya> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, philn |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alicia Boya García
LIFETIME_BOUND was added to GRefPtr.get() in
https://github.com/WebKit/WebKit/pull/44370
While it still makes sense to have that annotation, a couple build
errors due to false positives not caught in testing in
`Source/JavaScriptCore/API/glib/JSCContext.cpp` and
`Source/WebKit/WPEPlatform/wpe/WPESettings.cpp` have been identified,
making builds fail in clang.
This patch temporarily removes the LIFETIME_BOUND annotation of
GRefPtr.get() to make the builds work again and to buy some time to
analyze the errors in more detail and how they should be fixed.
* Source/WTF/wtf/glib/GRefPtr.h:
(WTF::GRefPtr::get const):
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alicia Boya García
Pull request: https://github.com/WebKit/WebKit/pull/44595
EWS
Committed 294179@main (79fc015c2885): <https://commits.webkit.org/294179@main>
Reviewed commits have been landed. Closing PR #44595 and removing active labels.
Michael Catanzaro
*** Bug 292097 has been marked as a duplicate of this bug. ***
Michael Catanzaro
Maybe we just won't be able to do this.