Bug 29212

Summary: bugzilla-tool rollout --complete-rollout should make a nicer bug comment
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bweinstein, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2009-09-11 16:38:54 PDT
bugzilla-tool rollout --complete-rollout should make a nicer bug comment

See:
https://bugs.webkit.org/show_bug.cgi?id=26700#c22

Committed r48321: <http://trac.webkit.org/changeset/48321>

It should probably mention that this is a rollout commit, and what revision it rolled out.
Comment 1 Eric Seidel (no email) 2009-12-19 23:52:03 PST
Actually it's gotten worse.  It's regressed to being the old-style comment:
https://bugs.webkit.org/show_bug.cgi?id=32738#c13

I blame adam!
Comment 2 Eric Seidel (no email) 2010-01-06 13:54:25 PST
*** Bug 30086 has been marked as a duplicate of this bug. ***
Comment 3 Eric Seidel (no email) 2010-01-06 13:55:21 PST
I've improved the comment and also made reopen_bug much more robust (per bug 30086).
Comment 4 Eric Seidel (no email) 2010-01-06 13:57:48 PST
Created attachment 45991 [details]
Patch
Comment 5 WebKit Review Bot 2010-01-06 13:58:35 PST
style-queue ran check-webkit-style on attachment 45991 [details] without any errors.
Comment 6 Adam Barth 2010-01-06 14:04:21 PST
Comment on attachment 45991 [details]
Patch

Death to FIXMES!
Comment 7 Eric Seidel (no email) 2010-01-06 14:14:18 PST
Comment on attachment 45991 [details]
Patch

Clearing flags on attachment: 45991

Committed r52870: <http://trac.webkit.org/changeset/52870>
Comment 8 Eric Seidel (no email) 2010-01-06 14:14:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Eric Seidel (no email) 2010-01-06 14:25:42 PST
Committed r52873: <http://trac.webkit.org/changeset/52873>