Bug 29202

Summary: bugzilla-tool post-diff should know how to mark commit-queue=?
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Severity: Normal CC: abarth, dglazkov, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Add --commit-queue support
Add --request-commit support abarth: review+, commit-queue: commit-queue-

Description Eric Seidel (no email) 2009-09-11 11:55:20 PDT
bugzilla-tool post-diff should know how to mark commit-queue=?

Would be easy to write.  The question is what the default should be.  I assume it should default to not marking.  Although maybe it should do a lookup of your bugzilla username in committers.py and default to true for non-committers?  Would that be too subtle?
Comment 1 Adam Barth 2009-09-11 11:56:29 PDT
I'm not sure this is worth doing by default.
Comment 2 Eric Seidel (no email) 2009-10-21 11:23:00 PDT
Created attachment 41588 [details]
Add --commit-queue support
Comment 3 Adam Barth 2009-10-21 12:34:18 PDT
Comment on attachment 41588 [details]
Add --commit-queue support

I don't think we should call it --commit-queue.  That name is already taken in land-patches as a command line argument.
Comment 4 Eric Seidel (no email) 2009-10-21 12:40:41 PDT
Well, it's very easy to change the name on land-patches, since that's only ever used by one person... me.  I think --commit-queue or --request-commit seem most appropriate to me.  do you have suggestions?
Comment 5 Eric Seidel (no email) 2009-10-21 12:51:56 PDT
--request-auto-commit could work too, but seems kinda long.
Comment 6 Adam Barth 2009-10-21 13:43:18 PDT
(In reply to comment #4)
>  --request-commit

I like this one.
Comment 7 Eric Seidel (no email) 2009-10-21 14:58:32 PDT
Created attachment 41613 [details]
Add --request-commit support
Comment 8 Adam Barth 2009-10-21 23:58:17 PDT
Comment on attachment 41613 [details]
Add --request-commit support

Comment 9 WebKit Commit Bot 2009-10-22 00:18:48 PDT
Comment on attachment 41613 [details]
Add --request-commit support

Rejecting patch 41613 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
tory/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/bugzilla.py
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:


    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/libexec/git-core//git-svn line 469
Comment 10 Eric Seidel (no email) 2009-10-22 00:20:34 PDT
I need to make svn-apply smarter to handle these ChagneLogs. :(
Comment 11 Eric Seidel (no email) 2009-10-26 15:40:08 PDT
svn-apply is now smarter, but waiting review.  Faster to just land this by hand.
Comment 12 Eric Seidel (no email) 2009-10-26 15:41:23 PDT
Committed r50107: <http://trac.webkit.org/changeset/50107>