Summary: | bugzilla-tool post-diff should know how to mark commit-queue=? | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | Tools / Tests | Assignee: | Eric Seidel (no email) <eric> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-09-11 11:55:20 PDT
I'm not sure this is worth doing by default. Created attachment 41588 [details]
Add --commit-queue support
Comment on attachment 41588 [details]
Add --commit-queue support
I don't think we should call it --commit-queue. That name is already taken in land-patches as a command line argument.
Well, it's very easy to change the name on land-patches, since that's only ever used by one person... me. I think --commit-queue or --request-commit seem most appropriate to me. do you have suggestions? --request-auto-commit could work too, but seems kinda long. (In reply to comment #4) > --request-commit I like this one. Created attachment 41613 [details]
Add --request-commit support
Comment on attachment 41613 [details]
Add --request-commit support
ok
Comment on attachment 41613 [details]
Add --request-commit support
Rejecting patch 41613 from commit-queue.
Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
tory/webkit/trunk ...
M WebKitTools/ChangeLog
M WebKitTools/Scripts/bugzilla-tool
M WebKitTools/Scripts/modules/bugzilla.py
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe
The following ChangeLog files contain OOPS:
trunk/WebKitTools/ChangeLog
Please don't ever say "OOPS" in a ChangeLog file.
at /usr/local/libexec/git-core//git-svn line 469
I need to make svn-apply smarter to handle these ChagneLogs. :( svn-apply is now smarter, but waiting review. Faster to just land this by hand. Committed r50107: <http://trac.webkit.org/changeset/50107> |