Bug 29202

Summary:

bugzilla-tool post-diff should know how to mark commit-queue=?

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Add --commit-queue support	none
Add --request-commit support	abarth: review+, commit-queue: commit-queue-

Eric Seidel (no email)

Reported 2009-09-11 11:55:20 PDT

bugzilla-tool post-diff should know how to mark commit-queue=? Would be easy to write. The question is what the default should be. I assume it should default to not marking. Although maybe it should do a lookup of your bugzilla username in committers.py and default to true for non-committers? Would that be too subtle?

Attachments
Add --commit-queue support (8.17 KB, patch) 2009-10-21 11:23 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Add --request-commit support (8.19 KB, patch) 2009-10-21 14:58 PDT, Eric Seidel (no email)	abarth: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-09-11 11:56:29 PDT

I'm not sure this is worth doing by default.

Eric Seidel (no email)

Comment 2 2009-10-21 11:23:00 PDT

Created attachment 41588 [details] Add --commit-queue support

Adam Barth

Comment 3 2009-10-21 12:34:18 PDT

Comment on attachment 41588 [details] Add --commit-queue support I don't think we should call it --commit-queue. That name is already taken in land-patches as a command line argument.

Eric Seidel (no email)

Comment 4 2009-10-21 12:40:41 PDT

Well, it's very easy to change the name on land-patches, since that's only ever used by one person... me. I think --commit-queue or --request-commit seem most appropriate to me. do you have suggestions?

Eric Seidel (no email)

Comment 5 2009-10-21 12:51:56 PDT

--request-auto-commit could work too, but seems kinda long.

Adam Barth

Comment 6 2009-10-21 13:43:18 PDT

(In reply to comment #4) > --request-commit I like this one.

Eric Seidel (no email)

Comment 7 2009-10-21 14:58:32 PDT

Created attachment 41613 [details] Add --request-commit support

Adam Barth

Comment 8 2009-10-21 23:58:17 PDT

Comment on attachment 41613 [details] Add --request-commit support ok

WebKit Commit Bot

Comment 9 2009-10-22 00:18:48 PDT

Comment on attachment 41613 [details] Add --request-commit support Rejecting patch 41613 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tory/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/bugzilla.py A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebKitTools/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469

Eric Seidel (no email)

Comment 10 2009-10-22 00:20:34 PDT

I need to make svn-apply smarter to handle these ChagneLogs. :(

Eric Seidel (no email)

Comment 11 2009-10-26 15:40:08 PDT

svn-apply is now smarter, but waiting review. Faster to just land this by hand.

Eric Seidel (no email)

Comment 12 2009-10-26 15:41:23 PDT

Committed r50107: <http://trac.webkit.org/changeset/50107>

Note You need to log in before you can comment on or make changes to this bug.