Bug 29196 – wx port is missing several filesystem functions in FileSystemWx.cpp

• Component: WebKit wx
• Status: RESOLVED WONTFIX

[Kevin Watters]

The wx port is missing a few FileSystemWx.cpp functions, which are prohibiting HTML5 local databases from being created and managed correctly.

[Kevin Watters]

Created attachment 39454 [details]
implements a few FileSystemWx.cpp functions

[Eric Seidel (no email)]

Comment on attachment 39454 [details]
implements a few FileSystemWx.cpp functions

This looks fine.  Except do you really want to use 0777?
 76     return wxFileName::Mkdir(path, 0777, wxPATH_MKDIR_FULL);

Wouldn't you want to respect the user's umask?  Or at least restrict these to rwx for the user?

[Kevin Ollivier]

Landed in r48344, thanks!(In reply to comment #2)
> (From update of attachment 39454 [details])
> This looks fine.  Except do you really want to use 0777?
>  76     return wxFileName::Mkdir(path, 0777, wxPATH_MKDIR_FULL);
> 
> Wouldn't you want to respect the user's umask?  Or at least restrict these to
> rwx for the user?

Sorry, didn't notice this comment somehow before landing the change. (r48344, BTW) After checking into it, I do see that the POSIX and GTK implementations do set umask to rwx for the user. Whether this is the right behavior for this API or not (vs. respecting the user's umask), I don't know, but it would seem that we run less risk of having unpredictable behavior by doing the same thing as other platforms. I'll leave this ticket open and work up a patch to change it if Kevin W. doesn't beat me to it. ;)

Thanks for catching this!

[Eric Seidel (no email)]

Comment on attachment 39454 [details]
implements a few FileSystemWx.cpp functions

Clearing r+ on this landed change.

It would be better to file a new bug to track the new change.