Bug 29195

Summary: Web Inspector Console should have scope bars
Product: WebKit Reporter: Brian Weinstein <bweinstein@apple.com>
Component: Web Inspector (Deprecated)Assignee: Brian Weinstein <bweinstein@apple.com>
Status: RESOLVED FIXED    
Severity: Normal CC: rik@webkit.org, timothy@apple.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 14353    
Attachments:
Description Flags
Console Scope Bars
timothy: review+, bweinstein: commit‑queue-
Screen Shot none

Description From 2009-09-11 11:18:17 PST
The Web Inspector Console should have scope bars.
------- Comment #1 From 2009-09-11 11:19:02 PST -------
Created an attachment (id=39452) [details]
Console Scope Bars
------- Comment #2 From 2009-09-11 11:27:40 PST -------
The console has a small vertical space, especially when the inspector is docked. Adding a scope bar reduces this space even more. Is there another way to add this functionality ? Maybe the horizontal space could be exploited.
------- Comment #3 From 2009-09-11 11:34:54 PST -------
This goes along the bottom bar, next to the "Clear Console" button, so it doesn't take up any extra vertical space. I'm attaching a screen shot after I write this comment.
------- Comment #4 From 2009-09-11 11:35:52 PST -------
Created an attachment (id=39455) [details]
Screen Shot

With errors and warnings selected.
------- Comment #5 From 2009-09-11 11:49:16 PST -------
Of course, the bottom bar. Disregard my previous comment.
------- Comment #6 From 2009-09-11 12:02:26 PST -------
(From update of attachment 39452 [details])
> +    var createFilterElement = function (category) {

This is better written as:

function createFilterElement(category)
{

> +     };

Thers is a stray indent space before the "}" brace. No need for the semicolon.

> +    display: list-item;

This should be display: block;

Looks good, if you fix these three things.
------- Comment #7 From 2009-09-11 13:46:47 PST -------
Committed in http://trac.webkit.org/changeset/48314