Bug 29192

Summary:

Allow WebKit clients to opt out of high resolution timers on Windows

Product:

WebKit

Reporter:

Steve Falkenburg <sfalken>

Component:

WebKit Misc.

Assignee:

Steve Falkenburg <sfalken>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows Vista

See Also:

https://bugs.webkit.org/show_bug.cgi?id=265748

Attachments:

Description	Flags
Add code to disable high-res timers conditionally	darin: review+
Fix bug with preferences to settings propagation	mitz: review+

Steve Falkenburg

Reported 2009-09-11 10:21:37 PDT

Gives WebKit embedders an option to opt out of high resolution timers. Default is that high resolution timers are enabled. If high res timers are disabled, all timers are fired via WM_TIMER. Also disables timeBeginPeriod/timeEndPeriod if high resolution timers are disabled.

Attachments
Add code to disable high-res timers conditionally (10.62 KB, patch) 2009-09-11 10:28 PDT, Steve Falkenburg	darin: review+	Details Formatted Diff Diff
Fix bug with preferences to settings propagation (1.71 KB, patch) 2009-09-11 16:44 PDT, Steve Falkenburg	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Falkenburg

Comment 1 2009-09-11 10:28:40 PDT

Created attachment 39448 [details] Add code to disable high-res timers conditionally

Darin Adler

Comment 2 2009-09-11 10:57:27 PDT

Comment on attachment 39448 [details] Add code to disable high-res timers conditionally I'm not sure PLATFORM(WIN) is the right ifdef. I think it's strange that we're naming the static data members with a "gX" naming scheme. This is not consistent with "m_".

Steve Falkenburg

Comment 3 2009-09-11 11:02:20 PDT

I'm not sure PLATFORM(WIN) fully represents this either, but this seems OK for now. I'd rather conditionalize it for now to the only platform where this is supported. The "g" naming matches the other static member in Settings. I agree it is a bit odd, and wonder about the utility of even putting this in a static data member vs. a static in the cpp file.

Steve Falkenburg

Comment 4 2009-09-11 11:05:13 PDT

r48308

Steve Falkenburg

Comment 5 2009-09-11 16:44:04 PDT

Created attachment 39491 [details] Fix bug with preferences to settings propagation

Note You need to log in before you can comment on or make changes to this bug.